Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't panic on connection closure #833

Merged
merged 1 commit into from
Mar 26, 2024
Merged

fix: don't panic on connection closure #833

merged 1 commit into from
Mar 26, 2024

Conversation

de-sh
Copy link
Contributor

@de-sh de-sh commented Mar 26, 2024

Solves #830

Type of change

Checklist:

  • Formatted with cargo fmt
  • Make an entry to CHANGELOG.md if it's relevant to the users of the library. If it's not relevant mention why.

@de-sh de-sh marked this pull request as ready for review March 26, 2024 08:02
@de-sh de-sh merged commit af55848 into main Mar 26, 2024
3 of 4 checks passed
@de-sh de-sh deleted the close branch March 26, 2024 08:16
@@ -64,6 +64,8 @@ pub enum StateError {
PubCompFail { reason: PubCompReason },
#[error("Connection failed with reason '{reason:?}' ")]
ConnFail { reason: ConnectReturnCode },
#[error("Connection closed by peer abruptly")]
ConnectionAborted
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would love to have this named ConnectionClosed. Think this is the term use widely when a read returns 0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants